Skip to content

[Geeks for Geeks Solution]: Fascinating Number #350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 2, 2024
Merged

[Geeks for Geeks Solution]: Fascinating Number #350

merged 3 commits into from
Jun 2, 2024

Conversation

iamanolive
Copy link
Contributor

resolves issue #345

@iamanolive iamanolive requested a review from ajay-dhangar as a code owner June 1, 2024 20:50
@vercel Vercel
Copy link

vercel bot commented Jun 1, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
codeharborhub-github-io ✅ Ready (Inspect) Visit Preview 💬 1 unresolved Jun 2, 2024 3:26am

@deepsource-io deepsource.io
Copy link
Contributor

deepsource-io bot commented Jun 1, 2024 •
edited
Loading

Here's the code health analysis summary for commits bd00372..28654c2. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource JavaScript LogoJavaScript✅ SuccessView Check ↗
💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@ajay-dhangar ajay-dhangar added documentation Improvements or additions to documentation enhancement New feature or request GSSOC'24 GirlScript Summer of Code | Contributor level2 GirlScript Summer of Code | Contributor's Levels gssoc GirlScript Summer of Code | Contributor labels Jun 2, 2024
@ajay-dhangar ajay-dhangar linked an issue Jun 2, 2024 that may be closed by this pull request
[Geeks for Geeks Solution]: Fascinating Number #345
Closed
4 tasks
ajay-dhangar
ajay-dhangar requested changes Jun 2, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change code for good practice

@iamanolive
Copy link
Contributor Author

@ajay-dhangar made the changes

@iamanolive
Copy link
Contributor Author

just asking for future reference, but what could i have done better in this for it to qualify as a level 3? @ajay-dhangar

ajay-dhangar
ajay-dhangar approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

@ajay-dhangar
Copy link
Member

just asking for future reference, but what could i have done better in this for it to qualify as a level 3? @ajay-dhangar

Please follow our structure, similar to the source code of the Two Sum problem, to ensure better understanding for everyone. You can also refer to the live preview for more details.

If you create the content according to this structure, I will assign it a level3 rating. However, if you cannot meet this requirement, I will need to update the content based on my specifications and assign you level2.

@ajay-dhangar
Copy link
Member

just asking for future reference, but what could i have done better in this for it to qualify as a level 3? @ajay-dhangar

Please follow our structure, similar to the source code of the Two Sum problem, to ensure better understanding for everyone. You can also refer to the live preview for more details.

If you create the content according to this structure, I will assign it a level3 rating. However, if you cannot meet this requirement, I will need to update the content based on my specifications and assign you level2.

I am waiting for your response. Would you like to update your content, or should I go ahead and merge it?

@iamanolive
Copy link
Contributor Author

just asking for future reference, but what could i have done better in this for it to qualify as a level 3? @ajay-dhangar

Please follow our structure, similar to the source code of the Two Sum problem, to ensure better understanding for everyone. You can also refer to the live preview for more details.
If you create the content according to this structure, I will assign it a level3 rating. However, if you cannot meet this requirement, I will need to update the content based on my specifications and assign you level2.

I am waiting for your response. Would you like to update your content, or should I go ahead and merge it?

I would like to update it

@iamanolive
Copy link
Contributor Author

@ajay-dhangar made changes

@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Jun 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@ajay-dhangar
Copy link
Member

@ajay-dhangar made changes

I check it.

ajay-dhangar
ajay-dhangar approved these changes Jun 2, 2024
View reviewed changes
Copy link
Member

@ajay-dhangar ajay-dhangar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay,

@ajay-dhangar ajay-dhangar added level3 GirlScript Summer of Code | Contributor's Levels and removed level2 GirlScript Summer of Code | Contributor's Levels labels Jun 2, 2024
@ajay-dhangar ajay-dhangar merged commit 54785f4 into codeharborhub:main Jun 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajay-dhangar ajay-dhangar ajay-dhangar approved these changes

Assignees

@iamanolive iamanolive

Labels
documentation Improvements or additions to documentation enhancement New feature or request gssoc GirlScript Summer of Code | Contributor GSSOC'24 GirlScript Summer of Code | Contributor level3 GirlScript Summer of Code | Contributor's Levels
Projects
@CodeHarborHub
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Geeks for Geeks Solution]: Fascinating Number
2 participants
@iamanolive @ajay-dhangar